Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(itest): run babylond in e2e #36

Merged
merged 5 commits into from
Sep 27, 2024
Merged

chore(itest): run babylond in e2e #36

merged 5 commits into from
Sep 27, 2024

Conversation

Lazar955
Copy link
Member

@Lazar955 Lazar955 commented Sep 26, 2024

Run babylond in e2e tests
Remove tools
Run in parallel 15m -> 4m

@RafilxTenfen
Copy link
Contributor

We have kind of duplicated code in multiple babylon side car repositories for e2e testing, any way we could bring this code to Babylon package e2e as an exported functions and import from there? Since these repositories already depend on Babylon imports packages

@Lazar955
Copy link
Member Author

We have kind of duplicated code in multiple babylon side car repositories for e2e testing, any way we could bring this code to Babylon package e2e as an exported functions and import from there? Since these repositories already depend on Babylon imports packages

@RafilxTenfen yeah, I agree that ideally this would be reused among side car repos. Will create an issue (in pm repo?) to add container package to Babylon. So we would justify it as a testing framework for side cars.

But it shouldn't block the merging of this PR.

Wdyt @KonradStaniec?

@KonradStaniec
Copy link
Collaborator

yeah, I agree that ideally this would be reused among side car repos. Will create an issue (in pm repo?) to add container package to Babylon. So we would justify it as a testing framework for side cars.

In general, I would prefer to keep Babylon node repo as minimal as possible, but given that alternative would be creating yet another repo for testing framework, I think I agree we can create separate package container in Babylon repo, and add readme there that it is a package to facilitate testing for programs which depends to Babylon. So 👍 on this from me.

* parallel go brrr

* cleanup

* pr comments
@Lazar955 Lazar955 requested a review from gitferry September 27, 2024 06:44
Copy link
Collaborator

@KonradStaniec KonradStaniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@Lazar955 Lazar955 merged commit a0a2db4 into main Sep 27, 2024
8 checks passed
@Lazar955 Lazar955 deleted the lazar/babylond-docker branch September 27, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants